Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add character limit on contest judging comment input frontend #11395

Closed
Tracked by #11403
venix12 opened this issue Aug 2, 2024 · 1 comment · Fixed by #11410
Closed
Tracked by #11403

Add character limit on contest judging comment input frontend #11395

venix12 opened this issue Aug 2, 2024 · 1 comment · Fixed by #11410
Assignees
@notbakaneko
Labels
area:contests type:behavioural

Comments

@venix12
Copy link
Member

venix12 commented Aug 2, 2024

Currently there is no input limit on the frontend, resulting in error when comment extends DB character limit.

Should probably use the limit + counter solution (mimicing beatmap discussions behaviour).
@venix12 venix12 mentioned this issue Aug 2, 2024
Open
@venix12 venix12 changed the title Add character limit on contest judging comment input Add character limit on contest judging comment input frontend Aug 2, 2024
@notbakaneko notbakaneko self-assigned this Aug 5, 2024
@notbakaneko
Copy link
Collaborator

I'm using this to tweak InputContainer some more 👀

@notbakaneko notbakaneko mentioned this issue Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@notbakaneko notbakaneko

Labels
area:contests type:behavioural
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor contest entry judging frontend notbakaneko/osu-web
2 participants
@notbakaneko @venix12