Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff_flashlight #322

Open
uzervlad opened this issue Nov 12, 2021 · 8 comments
Open

Add diff_flashlight #322

uzervlad opened this issue Nov 12, 2021 · 8 comments

Comments

@uzervlad
Copy link

As there is a new strain skill, it should be added to the API

@peppy
Copy link
Member

peppy commented Nov 12, 2021

Is this not exposed by the v2 API already? If so, I don't think we will be exposing new attributes here.

@uzervlad
Copy link
Author

No, v2 doesn't return any information about separate skills.

@peppy peppy self-assigned this Nov 15, 2021
@peppy
Copy link
Member

peppy commented Nov 15, 2021

That's a bit of an oversight. We'll need to add that eventually, but I'll see that this is added to the v1 API in the mean time.

@peppy
Copy link
Member

peppy commented Nov 16, 2021

Before I add this, what is the use case for using this?

@uzervlad
Copy link
Author

Just PP calculation. I don't think it can be used for anything else.
It's too hard to write and debug star rating calculation on my own, so I use values from API

@peppy
Copy link
Member

peppy commented Nov 17, 2021

Hmm, we already have tools which you can run to produce these locally, have you tried using those? I think that would be more efficient in most cases.

I'm just asking because I think 99% of use cases won't use this attribute and adding it bloats the response and the lookup overhead, potentially for no reason.

@TheEZIC
Copy link

TheEZIC commented Nov 17, 2021

I also need this, because I use it in my front-end only extension to calculate PP
github repository
google extension store page
I can't use v2 API. I don't remember exactly why, but the issue was related to converted beatmaps.

@uzervlad
Copy link
Author

uzervlad commented Nov 17, 2021

Hmm, we already have tools which you can run to produce these locally, have you tried using those?

Yes, I have, a rewrite of my bot uses lazer to calculate star rating and PP. But the current version is relying on values from API.
Actually, while writing this I realized that it shouldn't be too hard to connect lazer with the existing codebase.

@TheEZIC's use case, on the other hand, probably can't rely on any external tools, so if your only concerns are bloat and lookup overhead, you could add a query parameter for showing all difficulty attributes.

@peppy peppy removed their assignment Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants