-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add additional check for files that should be in lfs (even if they are below size threshold) #123
Comments
@naseemkullah thank you for this issue. I will be allocating some time to look into improvements as suggested. Please bare with me as I complete competing priorities before getting to this task. If you have some bandwidth, I am more than happy to review and approve a pull request ❤️ 🙇🏽 |
As for the implementation, I plan to iterate through the PR files and us Then among the PR files that should be stored in LFS (if any), check for the string |
@ppremk I added the functionality in the same PR that converts to TS, hope that is okay! (they are in separate commits), PTAL 🙏 |
e.g. If a user does not have lfs installed and checks in a jpg which is below the threshold set by this action, this action will pass.
I would like to add an additional check to see if lfs tracked files are indeed being checked in as LFS files, even if they are below the size threshold set by the warning.
I think these two checks are complimentary, where the size one warns users that they should use LFS to store a file (even if its .js or .json, etc.) the check I will be adding will make sure that a file that is lfs tracked is not accidentally committed as a regular binary file.
The text was updated successfully, but these errors were encountered: