From 751cf259b767246834905ca6a64cc1910dec3c4b Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Mon, 16 Oct 2023 17:33:52 +0200
Subject: [PATCH 1/7] Update Liquibase config

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 powsybl-parent/powsybl-parent-ws/pom.xml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/powsybl-parent/powsybl-parent-ws/pom.xml b/powsybl-parent/powsybl-parent-ws/pom.xml
index a8bf0c7..16c956a 100644
--- a/powsybl-parent/powsybl-parent-ws/pom.xml
+++ b/powsybl-parent/powsybl-parent-ws/pom.xml
@@ -50,7 +50,7 @@
         <git-id.failOnUnableToExtractRepoInfo>false</git-id.failOnUnableToExtractRepoInfo>
 
         <!-- for liquibase plugin -->
-        <liquibase-core.version>4.20.0</liquibase-core.version>
+        <liquibase-core.version>4.24.0</liquibase-core.version>
         <!--
           liquibase-hibernate6 4.20 (the same as liquibase-core) generates useless changesets, 4.23.2 doesn't seem to have this problem.
           for example, but maybe there are more
@@ -69,12 +69,12 @@
             still generates
             <modifyDataType columnName="myuuid" newDataType="bytea"/>
         -->
-        <liquibase-hibernate.version>4.23.2</liquibase-hibernate.version>
+        <liquibase-hibernate.version>4.24.0</liquibase-hibernate.version>
         <validation-api.version>3.0.2</validation-api.version>
         <liquibase-diff.outputFile>src/main/resources/db/changelog/changesets/changelog_${maven.build.timestamp}.xml</liquibase-diff.outputFile>
         <liquibase.username>sa</liquibase.username>
         <liquibase.databaseDriver>org.h2.Driver</liquibase.databaseDriver>
-        <liquibase.databaseUrl>jdbc:h2:./target/dummyDB</liquibase.databaseUrl>
+        <liquibase.databaseUrl>jdbc:h2:./target/dummyDB;MODE=PostgreSQL;DEFAULT_NULL_ORDERING=HIGH</liquibase.databaseUrl>
         <liquibase.referenceDatabaseUrl>hibernate:spring:${liquibase-hibernate-package}?dialect=org.hibernate.dialect.PostgreSQLDialect&amp;hibernate.physical_naming_strategy=org.hibernate.boot.model.naming.CamelCaseToUnderscoresNamingStrategy&amp;hibernate.implicit_naming_strategy=org.springframework.boot.orm.jpa.hibernate.SpringImplicitNamingStrategy</liquibase.referenceDatabaseUrl>
         <liquibase.referenceDatabaseDriver>liquibase.ext.hibernate.database.connection.HibernateDriver</liquibase.referenceDatabaseDriver>
         <liquibase-hibernate-package>PROPERTY_TO_BE_DEFINED_IN_PROJECTS</liquibase-hibernate-package>

From 5c5e167d97236a82ff0265625571ca02568a6e30 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Mon, 16 Oct 2023 17:35:26 +0200
Subject: [PATCH 2/7] Add Liquibase init script

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../resources/powsybl-build-tools/liquibase-h2-init.sql   | 3 +++
 powsybl-parent/pom.xml                                    | 2 +-
 powsybl-parent/powsybl-parent-ws/pom.xml                  | 8 +++++++-
 3 files changed, 11 insertions(+), 2 deletions(-)
 create mode 100644 powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
new file mode 100644
index 0000000..712b666
--- /dev/null
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -0,0 +1,3 @@
+CREATE DOMAIN JSONB AS JSON;
+/*CREATE DOMAIN OID AS BINARY LARGE OBJECT;*/
+/*create domain timestampstz as timestamp;*/
diff --git a/powsybl-parent/pom.xml b/powsybl-parent/pom.xml
index f8c974c..f3f3163 100644
--- a/powsybl-parent/pom.xml
+++ b/powsybl-parent/pom.xml
@@ -265,7 +265,7 @@
                           <dependency>
                             <groupId>com.powsybl</groupId>
                             <artifactId>powsybl-build-tools</artifactId>
-                            <version>18-SNAPSHOT</version>
+                            <version>${powsybl-build-tools.version}</version>
                           </dependency>
                         </dependencies>
                     </plugin>
diff --git a/powsybl-parent/powsybl-parent-ws/pom.xml b/powsybl-parent/powsybl-parent-ws/pom.xml
index 16c956a..942498e 100644
--- a/powsybl-parent/powsybl-parent-ws/pom.xml
+++ b/powsybl-parent/powsybl-parent-ws/pom.xml
@@ -74,7 +74,8 @@
         <liquibase-diff.outputFile>src/main/resources/db/changelog/changesets/changelog_${maven.build.timestamp}.xml</liquibase-diff.outputFile>
         <liquibase.username>sa</liquibase.username>
         <liquibase.databaseDriver>org.h2.Driver</liquibase.databaseDriver>
-        <liquibase.databaseUrl>jdbc:h2:./target/dummyDB;MODE=PostgreSQL;DEFAULT_NULL_ORDERING=HIGH</liquibase.databaseUrl>
+        <liquibase.databaseUrl>jdbc:h2:./target/dummyDB;MODE=PostgreSQL;DEFAULT_NULL_ORDERING=HIGH;INIT=runscript from 'classpath:/powsybl-build-tools/liquibase-h2-init.sql'</liquibase.databaseUrl>
+        <!--;DATABASE_TO_LOWER=TRUE-->
         <liquibase.referenceDatabaseUrl>hibernate:spring:${liquibase-hibernate-package}?dialect=org.hibernate.dialect.PostgreSQLDialect&amp;hibernate.physical_naming_strategy=org.hibernate.boot.model.naming.CamelCaseToUnderscoresNamingStrategy&amp;hibernate.implicit_naming_strategy=org.springframework.boot.orm.jpa.hibernate.SpringImplicitNamingStrategy</liquibase.referenceDatabaseUrl>
         <liquibase.referenceDatabaseDriver>liquibase.ext.hibernate.database.connection.HibernateDriver</liquibase.referenceDatabaseDriver>
         <liquibase-hibernate-package>PROPERTY_TO_BE_DEFINED_IN_PROJECTS</liquibase-hibernate-package>
@@ -203,6 +204,11 @@ jib.to.image = finalName;
                         <artifactId>jakarta.validation-api</artifactId>
                         <version>${validation-api.version}</version>
                     </dependency>
+                    <dependency>
+                        <groupId>com.powsybl</groupId>
+                        <artifactId>powsybl-build-tools</artifactId>
+                        <version>${powsybl-build-tools.version}</version>
+                    </dependency>
                 </dependencies>
 
             </plugin>

From 6ac7f947120b38a51979f3543db1cff710aaf308 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Tue, 17 Oct 2023 14:29:29 +0200
Subject: [PATCH 3/7] commit

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../resources/powsybl-build-tools/liquibase-h2-init.sql     | 6 +++---
 powsybl-parent/pom.xml                                      | 2 +-
 powsybl-parent/powsybl-parent-ws/pom.xml                    | 4 ++--
 3 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
index 712b666..a0d6c2a 100644
--- a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -1,3 +1,3 @@
-CREATE DOMAIN JSONB AS JSON;
-/*CREATE DOMAIN OID AS BINARY LARGE OBJECT;*/
-/*create domain timestampstz as timestamp;*/
+CREATE DOMAIN IF NOT EXISTS JSONB AS JSON;
+/*CREATE DOMAIN IF NOT EXISTS OID AS BINARY LARGE OBJECT;*/
+/*create domain if not exist timestampstz as timestamp;*/
diff --git a/powsybl-parent/pom.xml b/powsybl-parent/pom.xml
index f3f3163..f8c974c 100644
--- a/powsybl-parent/pom.xml
+++ b/powsybl-parent/pom.xml
@@ -265,7 +265,7 @@
                           <dependency>
                             <groupId>com.powsybl</groupId>
                             <artifactId>powsybl-build-tools</artifactId>
-                            <version>${powsybl-build-tools.version}</version>
+                            <version>18-SNAPSHOT</version>
                           </dependency>
                         </dependencies>
                     </plugin>
diff --git a/powsybl-parent/powsybl-parent-ws/pom.xml b/powsybl-parent/powsybl-parent-ws/pom.xml
index 942498e..6af016d 100644
--- a/powsybl-parent/powsybl-parent-ws/pom.xml
+++ b/powsybl-parent/powsybl-parent-ws/pom.xml
@@ -50,7 +50,7 @@
         <git-id.failOnUnableToExtractRepoInfo>false</git-id.failOnUnableToExtractRepoInfo>
 
         <!-- for liquibase plugin -->
-        <liquibase-core.version>4.24.0</liquibase-core.version>
+        <liquibase-plugin.version>4.24.0</liquibase-plugin.version>
         <!--
           liquibase-hibernate6 4.20 (the same as liquibase-core) generates useless changesets, 4.23.2 doesn't seem to have this problem.
           for example, but maybe there are more
@@ -177,7 +177,7 @@ jib.to.image = finalName;
             <plugin>
                 <groupId>org.liquibase</groupId>
                 <artifactId>liquibase-maven-plugin</artifactId>
-                <version>${liquibase-core.version}</version>
+                <version>${liquibase-plugin.version}</version>
                 <configuration>
                     <changeLogFile>src/main/resources/db/changelog/db.changelog-master.yaml</changeLogFile>
                     <diffChangeLogFile>${liquibase-diff.outputFile}</diffChangeLogFile>

From 987060cc5620a3a9ca1db8e0ebda9bf1db873180 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Tue, 17 Oct 2023 15:27:49 +0200
Subject: [PATCH 4/7] review

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../main/resources/powsybl-build-tools/liquibase-h2-init.sql  | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
index a0d6c2a..6852047 100644
--- a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -1,3 +1,7 @@
+/* Liquibase H2 database init script
+ * Due to some differences between H2 and PostgreSQL dialects, even with H2 compatibility mode,
+ * we need to add some little "hacks" to not have errors like "unknow type".
+ */;
 CREATE DOMAIN IF NOT EXISTS JSONB AS JSON;
 /*CREATE DOMAIN IF NOT EXISTS OID AS BINARY LARGE OBJECT;*/
 /*create domain if not exist timestampstz as timestamp;*/

From 77c047c7702d6ff8decb414f876292ebd8137d28 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Wed, 18 Oct 2023 10:00:26 +0200
Subject: [PATCH 5/7] review doc

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../main/resources/powsybl-build-tools/liquibase-h2-init.sql  | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
index 6852047..77c326d 100644
--- a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -1,7 +1,9 @@
 /* Liquibase H2 database init script
  * Due to some differences between H2 and PostgreSQL dialects, even with H2 compatibility mode,
- * we need to add some little "hacks" to not have errors like "unknow type".
+ * we need to add some little "hacks" to not have errors like "unknown type".
  */;
+
+/** There is some datatypes H2 in compatibility mode don"t take into account, so we create a domain/alias of equivalent type **/;
 CREATE DOMAIN IF NOT EXISTS JSONB AS JSON;
 /*CREATE DOMAIN IF NOT EXISTS OID AS BINARY LARGE OBJECT;*/
 /*create domain if not exist timestampstz as timestamp;*/

From a43e047ebdd04462a7a6b77ef4a0a2bf47e78b26 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Wed, 8 Nov 2023 16:36:59 +0100
Subject: [PATCH 6/7] review (clean code)

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../main/resources/powsybl-build-tools/liquibase-h2-init.sql | 3 +--
 powsybl-parent/powsybl-parent-ws/pom.xml                     | 5 ++---
 2 files changed, 3 insertions(+), 5 deletions(-)

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
index 77c326d..d70eeb3 100644
--- a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -2,8 +2,7 @@
  * Due to some differences between H2 and PostgreSQL dialects, even with H2 compatibility mode,
  * we need to add some little "hacks" to not have errors like "unknown type".
  */;
+/*keep these semi-colon for not having comments in output logs*/;
 
 /** There is some datatypes H2 in compatibility mode don"t take into account, so we create a domain/alias of equivalent type **/;
 CREATE DOMAIN IF NOT EXISTS JSONB AS JSON;
-/*CREATE DOMAIN IF NOT EXISTS OID AS BINARY LARGE OBJECT;*/
-/*create domain if not exist timestampstz as timestamp;*/
diff --git a/powsybl-parent/powsybl-parent-ws/pom.xml b/powsybl-parent/powsybl-parent-ws/pom.xml
index 6af016d..a587183 100644
--- a/powsybl-parent/powsybl-parent-ws/pom.xml
+++ b/powsybl-parent/powsybl-parent-ws/pom.xml
@@ -50,7 +50,7 @@
         <git-id.failOnUnableToExtractRepoInfo>false</git-id.failOnUnableToExtractRepoInfo>
 
         <!-- for liquibase plugin -->
-        <liquibase-plugin.version>4.24.0</liquibase-plugin.version>
+        <liquibase-plugin.version>4.20.0</liquibase-plugin.version>
         <!--
           liquibase-hibernate6 4.20 (the same as liquibase-core) generates useless changesets, 4.23.2 doesn't seem to have this problem.
           for example, but maybe there are more
@@ -69,13 +69,12 @@
             still generates
             <modifyDataType columnName="myuuid" newDataType="bytea"/>
         -->
-        <liquibase-hibernate.version>4.24.0</liquibase-hibernate.version>
+        <liquibase-hibernate.version>4.23.2</liquibase-hibernate.version>
         <validation-api.version>3.0.2</validation-api.version>
         <liquibase-diff.outputFile>src/main/resources/db/changelog/changesets/changelog_${maven.build.timestamp}.xml</liquibase-diff.outputFile>
         <liquibase.username>sa</liquibase.username>
         <liquibase.databaseDriver>org.h2.Driver</liquibase.databaseDriver>
         <liquibase.databaseUrl>jdbc:h2:./target/dummyDB;MODE=PostgreSQL;DEFAULT_NULL_ORDERING=HIGH;INIT=runscript from 'classpath:/powsybl-build-tools/liquibase-h2-init.sql'</liquibase.databaseUrl>
-        <!--;DATABASE_TO_LOWER=TRUE-->
         <liquibase.referenceDatabaseUrl>hibernate:spring:${liquibase-hibernate-package}?dialect=org.hibernate.dialect.PostgreSQLDialect&amp;hibernate.physical_naming_strategy=org.hibernate.boot.model.naming.CamelCaseToUnderscoresNamingStrategy&amp;hibernate.implicit_naming_strategy=org.springframework.boot.orm.jpa.hibernate.SpringImplicitNamingStrategy</liquibase.referenceDatabaseUrl>
         <liquibase.referenceDatabaseDriver>liquibase.ext.hibernate.database.connection.HibernateDriver</liquibase.referenceDatabaseDriver>
         <liquibase-hibernate-package>PROPERTY_TO_BE_DEFINED_IN_PROJECTS</liquibase-hibernate-package>

From 6e168d13500b47e69e63308877fdc7f584229918 Mon Sep 17 00:00:00 2001
From: Tristan Chuine <tristan.chuine_externe@rte-france.com>
Date: Thu, 21 Dec 2023 12:20:34 +0100
Subject: [PATCH 7/7] fix bad syntax for comments

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>
---
 .../main/resources/powsybl-build-tools/liquibase-h2-init.sql    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
index d70eeb3..34f0d8a 100644
--- a/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
+++ b/powsybl-build-tools/src/main/resources/powsybl-build-tools/liquibase-h2-init.sql
@@ -4,5 +4,5 @@
  */;
 /*keep these semi-colon for not having comments in output logs*/;
 
-/** There is some datatypes H2 in compatibility mode don"t take into account, so we create a domain/alias of equivalent type **/;
+/* There is some datatypes H2 in compatibility mode don't take into account, so we create a domain/alias of equivalent type */;
 CREATE DOMAIN IF NOT EXISTS JSONB AS JSON;