Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make use of JsonCracCreationContext #1083

Closed
pet-mit opened this issue Jul 5, 2024 · 0 comments
Closed

Make use of JsonCracCreationContext #1083

pet-mit opened this issue Jul 5, 2024 · 0 comments
Labels
cleaning This issue or pull request only concerns improving the overall state of the code experiment This subject is experimental and needs to be discussed thoroughly first feature New feature or request

Comments

@pet-mit
Copy link
Collaborator

pet-mit commented Jul 5, 2024

Describe the current behavior

JsonCracCreationContext has been created in #1069 but is not generally used in Json CRAC import. For instance, CRAC import fails when an extension is met.

Describe the expected behavior

Make use of this object and avoid throwing exceptions during import: instead, import information that is correct and log issues in JsonCracCreationContext.

Describe the motivation

Cleaner code, more robust Json CRAC importer

Extra Information

No response
@pet-mit pet-mit added feature New feature or request cleaning This issue or pull request only concerns improving the overall state of the code question Further information is requested experiment This subject is experimental and needs to be discussed thoroughly first and removed question Further information is requested labels Jul 5, 2024
@bqth29 bqth29 mentioned this issue Oct 18, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleaning This issue or pull request only concerns improving the overall state of the code experiment This subject is experimental and needs to be discussed thoroughly first feature New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pet-mit @Godelaine