[Issue-155] User setting of NULLCOST parameter #159
Conversation
Signed-off-by: marifunf <[email protected]>
|
There was a problem hiding this comment.
As requested in #155, the default value of the NULLCOST parameter should probably rather be set to negative infinity.
It could be done in configuration.cpp where the value is set to 0.5 (line 317)
However we might want to check the effect of this change on the computations, especially since it prevented having costs set to 0.
Would it be possible to add tests with uses of Metrix and where costs and NULLCOST are set to different values?
|
@klorel @nicolaslhuillier It seems that the costs used in the C++ part are defined as pbCoutLineaire_[numVar] = std::max(grp->coutHausseHR_, config::configuration().noiseCost())
+ config::configuration().adequacyCostOffset();Would it not be better to define the costs as |
|
The proposed solution should indeed work.
De : Nicolas Rol ***@***.***>
Envoyé : mercredi 17 juillet 2024 16:03
À : powsybl/powsybl-metrix ***@***.***>
Cc : LHUILLIER Nicolas ***@***.***>; Mention ***@***.***>
Objet : Re: [powsybl/powsybl-metrix] [Issue-155] User setting of NULLCOST parameter (PR #159)
EXPÉDITEUR EXTERNE: Ne cliquez sur aucun lien et n'ouvrez aucune pièce jointe à moins qu'ils ne proviennent d'un expéditeur fiable, ou que vous ayez l'assurance que le contenu provient d'une source sûre.
@klorel<https://github.com/klorel> @nicolaslhuillier<https://github.com/nicolaslhuillier>
What do you think of this?
It seems that the costs used in the C++ part are defined as costs = max(costs, NULLCOST) + ADEQUAOF, like for example:
pbCoutLineaire_[numVar] = std::max(grp->coutHausseHR_, config::configuration().noiseCost())
+ config::configuration().adequacyCostOffset();
Would it not be better to define the costs as costs = max(costs + ADEQUAOF, NULLCOST) so that NULLCOST is used for its purpose of avoiding costs at 0, without forbidding users to choose negative costs?
-
Reply to this email directly, view it on GitHub<#159 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGKBVR4R5JKK72XRKWFOWV3ZMZ2SRAVCNFSM6AAAAABKZFWACGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZTGQYDQOJVGY>.
You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
"Ce message est destiné exclusivement aux personnes ou entités auxquelles il est adressé et peut contenir des informations privilégiées ou confidentielles. Si vous avez reçu ce document par erreur, merci de nous l'indiquer par retour, de ne pas le transmettre et de procéder à sa destruction.
This message is solely intended for the use of the individual or entity to which it is addressed and may contain information that is privileged or confidential. If you have received this communication by error, please notify us immediately by electronic mail, do not disclose it and delete the original message."
|
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
Signed-off-by: Nicolas Rol <[email protected]>
|
|
I agree that it would be clearer. However, could we wait September to be able to test it for all users ? |
# Conflicts: # metrix-integration/src/test/java/com/powsybl/metrix/integration/MetrixParametersTest.java
|
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Fixes #155
What changes might users need to make in their application due to this PR? (migration steps)
Other information: