Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect coverage report probably due to groovy optimisation #111

Open
rolnico opened this issue Nov 10, 2023 · 3 comments
Open

Incorrect coverage report probably due to groovy optimisation #111

rolnico opened this issue Nov 10, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@rolnico
Copy link
Member

rolnico commented Nov 10, 2023

Describe the current behavior

Coverage report shows 6 uncovered conditions:
In the TimeSeriesDslLoader constructors creating a new GroovyCodeSource object, the coverage is partial (1 of 7 conditions covered).

Describe the expected behavior

There are no conditions to cover there.

Describe the steps

Test coverage on PR #103

Environment

No response

Relevant Log Output

No response

Extra Information

Might be due to groovy compiler optimisations

@rolnico rolnico added the bug Something isn't working label Nov 10, 2023
@rolnico
Copy link
Member Author

rolnico commented Nov 10, 2023

@olperr1
Copy link
Member

olperr1 commented Nov 13, 2023

In the CI, the Run SonarCloud analysis task of maven_ubuntu.yml is the one generating the jacoco reports. It uses already compiled java classes but it re-compiles the groovy code.
If maven options disabling groovy code optimization exist, they should be used at this step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants