Feature/Rewrite to async #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yllfejziu
force-pushed
the
feature/rewrite-to-async
branch
from
56e0b0f to
3e608d0
Compare
yllfejziu
force-pushed
the
feature/rewrite-to-async
branch
from
3e608d0 to
fe280ce
Compare
tonikocjan
reviewed
May 13, 2024
tonikocjan
reviewed
May 14, 2024
| /// Checks the current auth state and returns the boolean value as promise. | ||
| public var checkAuthentication: Promise<Authenticated> { | ||
| /// Checks the current auth state and returns the boolean value asynchronously. | ||
| public func checkAuthentication() async -> Authenticated { |
There was a problem hiding this comment.
Perhaps this function should be throwable and the error handled at the call site.
There was a problem hiding this comment.
And you can leave it as a getter as well. :) Though a function is fine by me as well.
There was a problem hiding this comment.
Let's remove this function completely. We have a mechanism in terms of notification about the revocation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a major update for PovioKitAuth. The old implementation with promises is overridden with async/await.
To be tested more for any edge cases before merging / releasing.
The following social connections need to be tested: