Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chart Ruler has invalid spacings in the initiation ShapeView #3

Open
pouyakary opened this issue Jul 11, 2021 · 2 comments
Open

Chart Ruler has invalid spacings in the initiation ShapeView #3

pouyakary opened this issue Jul 11, 2021 · 2 comments
Assignees
@pouyakary
Labels
State: Todo The issue is still in the todo list Type: Problem Something isn't working
Milestone
Version 1

Comments

@pouyakary
Copy link
Owner

No description provided.

@pouyakary pouyakary added the Type: Problem Something isn't working label Jul 11, 2021
@pouyakary pouyakary self-assigned this Jul 11, 2021
@pouyakary pouyakary added this to the Version 1 milestone Jul 11, 2021
@pouyakary pouyakary added the State: Todo The issue is still in the todo list label Jul 11, 2021
@hosseind88
Copy link

can I work on this issue?

@pouyakary
Copy link
Owner Author

You can certainly try. The bug is in the ./textkit/source/shapes/rulers/chart-rulers.ts. The ShapeView object expects its init lines to be the same length. The h-ruler has has two lines (one the ruler and one the numbers). You have to figure out which line is not spaced right.

You have to write the code with the KCS applied to it. It is a small bug, so if you don't apply KCS it will be far easier for me to just fix it instead of reviewing your code. You can also play around with the rulers in the ruler playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pouyakary pouyakary

Labels
State: Todo The issue is still in the todo list Type: Problem Something isn't working
Projects
None yet
Milestone
Version 1
Development

No branches or pull requests
2 participants
@pouyakary @hosseind88