changes / replicate should return a complete promise?

[daleharvey]

No description provided.

[calvinmetcalf]

+10000

[daleharvey]

Im gonna say this is a reasonably clear patch, goodfirstpatching

[calvinmetcalf]

A note to the fixer that you can't just use toPromise and you have to deal
with canceling.
On Feb 27, 2014 5:06 AM, "Dale Harvey" [email protected] wrote:

Im gonna say this is a reasonably clear patch, goodfirstpatching

Reply to this email directly or view it on GitHubhttps://github.com/daleharvey/pouchdb/issues/1521#issuecomment-36227226
.

[ig3]

Looking at this I see that Cancellation/A+, which bluebird seems to be following, suggests cancellation should reject a promise rather than resolve it. Recent changes to PouchDB make cancellation of changes more reliable, but with no error to the callback.

Perhaps now, as complete promises are being introduced, this should be revisited and cancellation should return an error to callbacks and rejection of the promise.

I am working on a change to changes in adapter.js to return a complete promise and, at the moment to return an error on cancellation, but it is easy enough to go either way with the return.

Might a change to returning an error/rejection on cancel be accepted?

[calvinmetcalf]

I think the main focus should be on making it a readable stream first, and then promise second, there is no reason it can't be both but a stream is going to be the more natural way to get data, the main hurdle there is going to be pausing the stream which is currently impossible to do.

[calvinmetcalf]

this is done