Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with yarn PnP #118

Closed
LeaderbotX400 opened this issue Jan 11, 2023 · 5 comments
Closed

Not working with yarn PnP #118

LeaderbotX400 opened this issue Jan 11, 2023 · 5 comments
Labels
👍 contribution welcome others are welcome to implement/fix this

Comments

@LeaderbotX400
Copy link

When I attempt to load a new project using yarn pnp I get this lovely error

failed to load config from C:\projects\sites\router-testing\vite.config.ts
error when starting dev server:
Error: unplugin-vue-router tried to access @vue/compiler-sfc, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @vue/compiler-sfc (via "@vue\compiler-sfc")
Required by: unplugin-vue-router@virtual:a40d5af684f311521e9b2d5690fe3b63a250057a024ba8545fc41a891cd10652153ebee5739b4fcefee17ac8258089cc08af32f733ef452ce315014b7fdd537d#npm:0.3.2 (via C:\projects\sites\router-testing\.yarn\__virtual__\unplugin-vue-router-virtual-cf8f385e08\0\cache\unplugin-vue-router-npm-0.3.2-a2fd1b41f4-4f33822665.zip\node_modules\unplugin-vue-router\dist\)

Require stack:
- C:\projects\sites\router-testing\.yarn\__virtual__\unplugin-vue-router-virtual-cf8f385e08\0\cache\unplugin-vue-router-npm-0.3.2-a2fd1b41f4-4f33822665.zip\node_modules\unplugin-vue-router\dist\vite.js
- C:\projects\sites\router-testing\vite.config.ts
- C:\projects\sites\router-testing\.yarn\__virtual__\vite-virtual-b56c81fe45\0\cache\vite-npm-4.0.4-33a47fc7a2-eb86c8cdfe.zip\node_modules\vite\dist\node\chunks\dep-5e7f419b.js
    at require$$0.Module._resolveFilename (C:\projects\sites\router-testing\.pnp.cjs:19002:13)
    at require$$0.Module._load (C:\projects\sites\router-testing\.pnp.cjs:18852:42)
    at Module.require (node:internal/modules/cjs/loader:1105:19)
    at require (node:internal/modules/cjs/helpers:103:18)
    at Object.<anonymous> (C:\projects\sites\router-testing\.yarn\__virtual__\unplugin-vue-router-virtual-cf8f385e08\0\cache\unplugin-vue-router-npm-0.3.2-a2fd1b41f4-4f33822665.zip\node_modules\unplugin-vue-router\dist\vite.js:560:27)
    at Module._compile (node:internal/modules/cjs/loader:1218:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1272:10)
    at require$$0.Module._extensions..js (C:\projects\sites\router-testing\.pnp.cjs:19046:33)
    at _require.extensions.<computed> [as .js] (file:///C:/projects/sites/router-testing/.yarn/__virtual__/vite-virtual-b56c81fe45/0/cache/vite-npm-4.0.4-33a47fc7a2-eb86c8cdfe.zip/node_modules/vite/dist/node/chunks/dep-5e7f419b.js:62106:17)
    at Module.load (node:internal/modules/cjs/loader:1081:32)

once I set yarn to use node-modules instead of the new pnp api it works just fine

@LeaderbotX400 LeaderbotX400 changed the title Add support for Yarn PnP Not working with yarn PnP Jan 11, 2023
@posva
Copy link
Owner

posva commented Jan 11, 2023

I don’t use pnp so any help for this is welcome!

@LeaderbotX400
Copy link
Author

LeaderbotX400 commented Jan 16, 2023

UPDATE: there is a work around

Edit the .yarnrc.yml file to contain the following

packageExtensions:
  unplugin-vue-router@*:
    dependencies:
      "@vue/compiler-sfc": "*"

@wearypossum4770
Copy link

So I ran into the same issue but found the import statement needed work. I am using yarn berry currently version 3.5.1. The following change was sufficient.

-import { createRouter, createWebHistory } from 'vue-router/auto'
+import { createRouter, createWebHistory } from 'vue-router-auto'

@phamhongphuc
Copy link

I also got the same issue.
I tried several different combinations and create a simple repo here (without any plugin) to reproduce the bug, hope it helps.

Node 20.11.1+ Yarn 3.8.1 + pnp
Node 20.11.1+ Yarn 3.8.1 + pnpm
Node 20.11.1+ Yarn 3.8.1 + node-modules ✔️

@posva
Copy link
Owner

posva commented Sep 2, 2024

I think this should be fine after the changes to vue-router and this package. If not, let me know with a boiled down reproduction

@posva posva closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👍 contribution welcome others are welcome to implement/fix this
Projects
None yet
Development

No branches or pull requests

4 participants