Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pickup location Delivery Date Check #376

Closed
kaplansin opened this issue Dec 29, 2023 · 1 comment
Closed

Pickup location Delivery Date Check #376

kaplansin opened this issue Dec 29, 2023 · 1 comment

Comments

@kaplansin
Copy link

To Reproduce
Steps to reproduce the behavior:

  1. Add Item into your cart,
  2. Go to checkout,
  3. Select PostNL as shipping
  4. Select Pickup location.
  5. Finalize the order.
  6. Create an other quote.
  7. Goto Checkout
  8. Select PostNL as shipping
  9. Select Pickup location.
  10. /postnl/deliveryoptions/save request will fail.

Expected result
/postnl/deliveryoptions/save must return 'ok' and Order shipping address must selected Pickup location address.

Actual result
/postnl/deliveryoptions/save fails with 500 Internal Server Error.
And Order will not have Pickup location address as Shipping address.

Workaround
Logout and Login and continue payment processes.

** Please complete the following information**

  • Magento version: 2.4.6-p3
  • PHP version: PHP 8.1.4
  • TIG PostNL version: 1.13.0
@DarthFly
Copy link
Contributor

DarthFly commented Jan 9, 2024

Hi @kaplansin
We tried to reproduce it but were not able to do this for now. Could you be able to try to reproduce this issue on https://public.postnlmagento2.hypernode.io ? If it's reproduced - please give us the first order number that you placed before error 500.

Your PR does makes sense, but it seems like the reason why the "date" is empty should go from the incorrect response in the first place and we would like to see why it ends up that way.

@JorisPostNL JorisPostNL closed this as not planned Won't fix, can't repro, duplicate, stale Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants