From 074987110d5e0586d971e0f39c2174eb17621d42 Mon Sep 17 00:00:00 2001 From: Damir Date: Thu, 3 Nov 2022 02:08:01 +0100 Subject: [PATCH] Remove attributes with undefined or null value --- changelog.md | 4 ++++ docs-src/md/changelog.md | 4 ++++ docs-src/pages/index.html | 2 +- docs/demo.html | 7 +++++++ docs/docs.html | 7 +++++++ docs/index.html | 9 ++++++++- docs/test.html | 7 +++++++ package.json | 2 +- src/process-attributes.js | 8 ++++++++ test/templates/components/remove-attributes.html | 7 +++++++ test/test-attributes.js | 9 +++++++++ 11 files changed, 63 insertions(+), 3 deletions(-) create mode 100644 test/templates/components/remove-attributes.html diff --git a/changelog.md b/changelog.md index edeec3f..1528427 100644 --- a/changelog.md +++ b/changelog.md @@ -1,3 +1,7 @@ +## 1.0.0-beta.13 (2022-11-03) + +* Remove attributes that have "undefined" or "null" value + ## 1.0.0-beta.12 (2022-10-31) * Added more utilities diff --git a/docs-src/md/changelog.md b/docs-src/md/changelog.md index 445cc6b..226311e 100644 --- a/docs-src/md/changelog.md +++ b/docs-src/md/changelog.md @@ -1,3 +1,7 @@ +## 1.0.0-beta.13 (2022-11-03) + +* Remove attributes that have "undefined" or "null" value + ## 1.0.0-beta.12 (2022-10-31) * Added more utilities diff --git a/docs-src/pages/index.html b/docs-src/pages/index.html index 1ed568a..41ae05f 100644 --- a/docs-src/pages/index.html +++ b/docs-src/pages/index.html @@ -14,7 +14,7 @@

Build the web with PostHTML

- Currently v1.0.0-beta.12 + Currently v1.0.0-beta.13 · Changelog

diff --git a/docs/demo.html b/docs/demo.html index 3b01831..778bd4f 100644 --- a/docs/demo.html +++ b/docs/demo.html @@ -77,6 +77,13 @@
+

+ # + 1.0.0-beta.13 (2022-11-03) +

+

# 1.0.0-beta.12 (2022-10-31) diff --git a/docs/docs.html b/docs/docs.html index f385174..916a10b 100644 --- a/docs/docs.html +++ b/docs/docs.html @@ -1488,6 +1488,13 @@

+

+ # + 1.0.0-beta.13 (2022-11-03) +

+

# 1.0.0-beta.12 (2022-10-31) diff --git a/docs/index.html b/docs/index.html index 08fcd8c..a4f03c1 100644 --- a/docs/index.html +++ b/docs/index.html @@ -59,7 +59,7 @@

Build the web with PostHTML

Currently - v1.0.0-beta.12 + v1.0.0-beta.13 · Changelog

@@ -93,6 +93,13 @@
+

+ # + 1.0.0-beta.13 (2022-11-03) +

+

# 1.0.0-beta.12 (2022-10-31) diff --git a/docs/test.html b/docs/test.html index 7b5f5ba..2502606 100644 --- a/docs/test.html +++ b/docs/test.html @@ -221,6 +221,13 @@

+

+ # + 1.0.0-beta.13 (2022-11-03) +

+

# 1.0.0-beta.12 (2022-10-31) diff --git a/package.json b/package.json index 37b0cf2..e23b425 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "posthtml-component", - "version": "1.0.0-beta.12", + "version": "1.0.0-beta.13", "description": "PostHTML Components Blade-like with slots, attributes as props and custom tag", "license": "MIT", "repository": "thewebartisan7/posthtml-components", diff --git a/src/process-attributes.js b/src/process-attributes.js index 7bffcc7..c2e829d 100644 --- a/src/process-attributes.js +++ b/src/process-attributes.js @@ -60,5 +60,13 @@ module.exports = (currentNode, attributes, props, options) => { delete attributes[key]; }); + // Remove an attribute if value is 'null' or 'undefined' + // so we can conditionally add an attribute + each(nodeAttrs, (value, key) => { + if (['undefined', 'null'].includes(value)) { + delete nodeAttrs[key]; + } + }); + mainNode.attrs = nodeAttrs.compose(); }; diff --git a/test/templates/components/remove-attributes.html b/test/templates/components/remove-attributes.html new file mode 100644 index 0000000..7adc83c --- /dev/null +++ b/test/templates/components/remove-attributes.html @@ -0,0 +1,7 @@ + + diff --git a/test/test-attributes.js b/test/test-attributes.js index be0bd81..e9b6790 100644 --- a/test/test-attributes.js +++ b/test/test-attributes.js @@ -49,3 +49,12 @@ test('Must override class and style attributes', async t => { t.is(html, expected); }); + +test('Must remove an attributes that has "undefined" or "null" value', async t => { + const actual = `My button`; + const expected = ``; + + const html = await posthtml([plugin({root: './test/templates', tag: 'component'})]).process(actual).then(result => clean(result.html)); + + t.is(html, expected); +});