-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AMP support #57
Comments
Totally! I'll appreaciate it if you implement these minifications. |
#59 adds some of the things mentioned. I'll still need to look into whether additions can be made to |
I think I'll close this for now. It seems AMP support is in a good place now based on my testing - if we missed something, it's easy to reopen. |
I'm experimenting with using PostHTML and htmlnano with a page I've built using AMP and, while it works fine right now (as AMP is just HTML), I think there are some minor tweaks to htmlnano that would make it even more useful.
Notably:
collapseBooleanAttributes
, such asamp
,amp-custom
,amp-boilerplate
.mergeStyles
andminifyCss
should ignore the AMP boilerplate (<style amp-boilerplate>...</style>
).amp-custom
should be preserved on the merged<style>
tags, if present (maybe just include this instyleKey
).removeRedundantAttributes
andremoveEmptyAttributes
(still looking into this).I'm happy to send a PR with these changes, but wanted to start some discussion first. Would you be OK with accepting these additions to htmlnano?
The text was updated successfully, but these errors were encountered: