Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with async/promises? #72

Closed
sebdeckers opened this issue Jan 27, 2017 · 3 comments
Closed

Problem with async/promises? #72

sebdeckers opened this issue Jan 27, 2017 · 3 comments
Milestone
0.0.8

Comments

@sebdeckers
Copy link
Contributor

I'm trying to use posthtml CLI with the nanohtml plugin which returns a promise. Unfortunately posthtml renders the output before the promise from nanohtml resolves. I might be wrong but I think the problem lies in how post-load-plugins ignores promises and calls res() (the callback) before even invoking the plugin, and completely ignoring the returned tree. See: https://github.com/post-org/post-load-plugins/blob/master/src/index.js#L37
@Scrum Scrum added this to the 0.0.8 milestone Jan 31, 2017
@Scrum Scrum added the invalid label Jan 31, 2017
@Scrum
Copy link
Collaborator

Scrum commented Jan 31, 2017

related post/post-config#62

@Scrum Scrum closed this as completed in 74b83e2 Jan 31, 2017
@Scrum
Copy link
Collaborator

Scrum commented Jan 31, 2017

@sebdeckers watch PR

@Scrum
Copy link
Collaborator

Scrum commented Feb 1, 2017 •
edited
Loading

@sebdeckers now you need update/reinstall posthtml-cli. Thanks for feedback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.8
Development

No branches or pull requests
2 participants
@sebdeckers @Scrum