feat(popover): behavior and design #472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for 36be0e6 at https://positive-js.github.io/mosaic-previews/pr472-36be0e6/ |
|
Preview docs changes for 3474109 at https://positive-js.github.io/mosaic-previews/pr472-3474109/ |
|
Preview docs changes for 23761a1 at https://positive-js.github.io/mosaic-previews/pr472-23761a1/ |
pimenovoleg
approved these changes
Jun 3, 2020
|
Kudos, SonarCloud Quality Gate passed!
|
pimenovoleg
changed the title
pimenovoleg
pushed a commit
that referenced
this pull request
Jun 3, 2020
pimenovoleg
pushed a commit
that referenced
this pull request
Jun 3, 2020
pimenovoleg
pushed a commit
that referenced
this pull request
Jun 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fost @mikeozornin @cooleso
Small improvement.
Distance between popover container and anchor reduced
Minimal anchor height and width set to 40px, so in case of larger elements popover positions such as topRight etc. will be set as usual to corresponding anchor corner, otherwise - arrow will try to point to anchor element center.