fix(navbar): fixing navbar disabled item opacity (#UIM-396) #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for 5280239 at https://positive-js.github.io/mosaic-previews/pr440-5280239/ |
Margar1ta
changed the title
lskramarov
reviewed
Mar 23, 2020
| @@ -50,7 +50,7 @@ | |||
| &[disabled] { | |||
| .mc-navbar-title, | |||
| .mc-icon { | |||
| opacity: map-get($navbar, item_state-disabled_opacity); | |||
| opacity: 0.3; | |||
There was a problem hiding this comment.
На синке обсуждали, нужно вернуть параметр в токены.
И возможно добавить в токены другие параметры opacity.
|
Preview docs changes for 071a308 at https://positive-js.github.io/mosaic-previews/pr440-071a308/ |
|
Kudos, SonarCloud Quality Gate passed!
|
|
Preview docs changes for 23fe28a at https://positive-js.github.io/mosaic-previews/pr440-23fe28a/ |
lskramarov
approved these changes
Mar 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.