feat(date-formatter): update range dates formatter to show current year in some cases #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@roll314 добавь пжл более ясное описание в PR и название |
roll314
changed the title
roll314
changed the title
|
А почему здесь в английском другой год? http://d.mikeozornin.ru/jhaUuG |
|
косяк примера, поправлю |
|
обновил пример |
lskramarov
approved these changes
Jun 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fost
@lskramarov
@mikeozornin
TFS - 185214
Паста от Мишы
По нашему формату мы не пишем год, когда он текущий. Это приводит к таким картинкам:
http://screenshots.ptsecurity.com/mozornin-2019-06-04_14-11-36.png
Догадаться, что это 2019 невозможно, это небольшая катастрофа. Хочется переработать диапазоны.
Сейчас: Если год текущий на одном из концов, то его не пишем
Надо бы: Если год текущий на обоих концах совпадает, то их оба не пишем.
Примеры здесь: wiki - 20332985 исправлены