fix(list): Некорректное выделение в McList (#176613) #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimenovoleg
approved these changes
May 28, 2019
|
осталось посмотреть, что там с тестами |
pimenovoleg
reviewed
May 28, 2019
pimenovoleg
reviewed
May 28, 2019
pimenovoleg
approved these changes
May 29, 2019
|
@mikeozornin waiting for you ^) |
mikeozornin
suggested changes
May 30, 2019
There was a problem hiding this comment.
У меня исходная проблема починилась.
Но другая, сходная не починилась (в сторибуке сейчас тоже есть). Если другую надо отдельным багом — то ок, можно считать что я заапрувил этот ПР.
Выбираю второй элемент.
Нажимаю шифт и кликаю по четвертому.
Ожидание:
Выберутся 2, 3, 4.
Реальность:
Выбираются 1, 2, 3, 4 (1 лишний).
pimenovoleg
pushed a commit
that referenced
this pull request
Jun 3, 2019
* removed console.log * fixed tests and some logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Кроме самого фикса поправил ошибки линтера в этом компоненте.