fix(tooltip): Missing hide call when mcDisabled set to true #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fost , @lskramarov please take a look. |
pimenovoleg
approved these changes
May 7, 2019
LeonVay
deleted the
fix/fix(tooltip)_Missing_hide_call_when_mcDisabled_set_to_true
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fost , @lskramarov please take a look.
Previously I've forgot to call
hidemethod in case if mcDisabledTooltip set to false, which trigger changes and setmcVisibleto false. So the code flow looks like this:mcTooltipDisabled => set to true => emmit changes => show => ok => mcTooltipDisabled => set to false => emit changes => mcVisible set to false => trigger hide