diff --git a/packages/cdk/datetime/date-adapter.ts b/packages/cdk/datetime/date-adapter.ts index 8a9ac01d4..38329daf4 100644 --- a/packages/cdk/datetime/date-adapter.ts +++ b/packages/cdk/datetime/date-adapter.ts @@ -60,8 +60,7 @@ export abstract class DateAdapter { return this._localeChanges; } - // tslint:disable-next-line:naming-convention - protected _localeChanges = new Subject(); + private _localeChanges = new Subject(); /** * Gets the year component of the given date. diff --git a/packages/mosaic/input/input.ts b/packages/mosaic/input/input.ts index 39f2a2154..b82dd4fd4 100644 --- a/packages/mosaic/input/input.ts +++ b/packages/mosaic/input/input.ts @@ -325,8 +325,7 @@ export class McInput extends McInputMixinBase implements McFormFieldControl } } - // tslint:disable-next-line: naming-convention - protected _disabled = false; + private _disabled = false; /** * Implemented as part of McFormFieldControl. @@ -341,8 +340,7 @@ export class McInput extends McInputMixinBase implements McFormFieldControl this._id = value || this.uid; } - // tslint:disable-next-line: naming-convention - protected _id: string; + private _id: string; /** * Implemented as part of McFormFieldControl. @@ -357,8 +355,7 @@ export class McInput extends McInputMixinBase implements McFormFieldControl this._required = coerceBooleanProperty(value); } - // tslint:disable-next-line: naming-convention - protected _required = false; + private _required = false; // tslint:disable no-reserved-keywords /** Input type of the element. */ @@ -380,8 +377,7 @@ export class McInput extends McInputMixinBase implements McFormFieldControl } // tslint:enable no-reserved-keywords - // tslint:disable-next-line: naming-convention - protected _type = 'text'; + private _type = 'text'; /** * Implemented as part of McFormFieldControl. diff --git a/packages/mosaic/modal/modal.component.ts b/packages/mosaic/modal/modal.component.ts index 5ae6d0825..893838072 100644 --- a/packages/mosaic/modal/modal.component.ts +++ b/packages/mosaic/modal/modal.component.ts @@ -65,8 +65,7 @@ export class McModalComponent extends McModalRef get mcVisible() { return this._mcVisible; } set mcVisible(value) { this._mcVisible = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcVisible = false; + private _mcVisible = false; @Output() mcVisibleChange = new EventEmitter(); @@ -81,20 +80,17 @@ export class McModalComponent extends McModalRef @Input() get mcClosable() { return this._mcClosable; } set mcClosable(value) { this._mcClosable = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcClosable = true; + private _mcClosable = true; @Input() get mcMask() { return this._mcMask; } set mcMask(value) { this._mcMask = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcMask = true; + private _mcMask = true; @Input() get mcMaskClosable() { return this._mcMaskClosable; } set mcMaskClosable(value) { this._mcMaskClosable = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcMaskClosable = false; + private _mcMaskClosable = false; @Input() mcMaskStyle: object; @Input() mcBodyStyle: object; @@ -111,8 +107,7 @@ export class McModalComponent extends McModalRef @Input() get mcOkLoading() { return this._mcOkLoading; } set mcOkLoading(value) { this._mcOkLoading = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcOkLoading = false; + private _mcOkLoading = false; @Input() @Output() mcOnOk: EventEmitter | OnClickCallback = new EventEmitter(); @Input() mcCancelText: string; @@ -120,8 +115,7 @@ export class McModalComponent extends McModalRef @Input() get mcCancelLoading() { return this._mcCancelLoading; } set mcCancelLoading(value) { this._mcCancelLoading = value; } - // tslint:disable-next-line:orthodox-getter-and-setter , naming-convention could be private? - _mcCancelLoading = false; + private _mcCancelLoading = false; @Input() @Output() mcOnCancel: EventEmitter | OnClickCallback = new EventEmitter(); diff --git a/packages/mosaic/tags/tag-list.component.ts b/packages/mosaic/tags/tag-list.component.ts index e9d7a0d0e..2032feccf 100644 --- a/packages/mosaic/tags/tag-list.component.ts +++ b/packages/mosaic/tags/tag-list.component.ts @@ -283,7 +283,6 @@ export class McTagList extends McTagListMixinBase implements McFormFieldControl< descendants: true }) tags: QueryList; - // public property with setter - should be private? // tslint:disable-next-line: naming-convention orthodox-getter-and-setter _tabIndex = 0; diff --git a/packages/mosaic/textarea/textarea.component.ts b/packages/mosaic/textarea/textarea.component.ts index 96c2e8d8b..9d31bbabf 100644 --- a/packages/mosaic/textarea/textarea.component.ts +++ b/packages/mosaic/textarea/textarea.component.ts @@ -147,11 +147,9 @@ export class McTextarea extends McTextareaMixinBase implements McFormFieldContro protected uid = `mc-textsrea-${nextUniqueId++}`; protected previousNativeValue: any; - // tslint:disable:naming-convention - protected _disabled = false; - protected _id: string; - protected _required = false; - // tslint:enable:naming-convention + private _disabled = false; + private _id: string; + private _required = false; private valueAccessor: { value: any }; private growSubscription: Subscription;