New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How should we deprecate methods? #344

Closed

schloerke opened this issue Nov 22, 2024 · 1 comment

Labels

sdk

Collaborator

schloerke commented Nov 22, 2024

Is this a behavior we want to override?

There does appear to be some churn in how silent these are: https://docs.python.org/3/library/warnings.html#default-warning-filter but it smells a bit funny to me to wrap around core language functionality / expectations. Not saying we absolutely shouldn't but this might be a larger conversation than this PR?

Originally posted by @jonkeane in #339 (comment)

github-actions bot added the sdk label

schloerke mentioned this issue

feat: Add Permissions.delete(*permissions) method #339

Merged

Collaborator Author

schloerke commented Nov 22, 2024

Closing as deprecations should not be handed right now.

Instead the method should just be replaced.

Related: #339 (comment)

schloerke closed this as not planned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment