Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Content Vanity API #175

Closed
tdstein opened this issue Apr 18, 2024 · 1 comment · Fixed by #310
Closed

Implement Content Vanity API #175

tdstein opened this issue Apr 18, 2024 · 1 comment · Fixed by #310
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers sdk Used for automation
Milestone

Comments

@tdstein
Copy link
Collaborator

tdstein commented Apr 18, 2024

Content Vanity API

v0.6.0 Proposal

from posit import connect

client = connect.Client()
content = client.content.get(...)

vanity = content.vanity = ...
del content.vanity

vanity.destroy()
@tdstein tdstein added enhancement New feature or request good first issue Good for newcomers labels Apr 18, 2024
@tdstein tdstein added this to the 0.4.0 milestone Apr 26, 2024
@nealrichardson
Copy link
Collaborator

Following https://github.com/rstudio/connect/pull/27252, we should add vanity_url to the default include specification (and also add include to the content item GET request). Then for the vanity_url @property, if the field is not set, do GET /__api__/v1/content/{guid}/vanity to resolve it (that API was added in 2020: https://github.com/rstudio/connect/pull/18448).

Ideally we should be able to distinguish between "There is no vanity URL for this content" and "I haven't asked for the vanity URL yet" so we don't make extra requests, but that's probably not a huge concern (until we learn otherwise).

@tdstein tdstein removed this from the 0.4.0 milestone Sep 4, 2024
@tdstein tdstein added the sdk Used for automation label Sep 13, 2024
@tdstein tdstein changed the title Vanity URLs Implement Vanity URLs API Sep 13, 2024
@tdstein tdstein added this to the 0.6.0 milestone Sep 25, 2024
@tdstein tdstein changed the title Implement Vanity URLs API Implement Vanity API Sep 27, 2024
@tdstein tdstein changed the title Implement Vanity API Implement Content Vanity API Sep 27, 2024
@tdstein tdstein self-assigned this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers sdk Used for automation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants