Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Google Cloud regional workers and improvements #49

Merged
merged 4 commits into from
Nov 4, 2017
Merged

Google Cloud regional workers and improvements #49

merged 4 commits into from
Nov 4, 2017

Commits on Nov 4, 2017

  1. Change worker managed instance group to span zones in region 

    * Change Google Cloud module to require the `region` variable
* Workers are created in random zones within the given region
* Tolerate Google Cloud zone failures or capacity issues
* If workers are preempted (if enabled), replacement instances can
be drawn from any zone in the region, which should avoid scheduling
issues that were possible before if a single zone aggressively
preempts instances (presumably due to Google Cloud capacity)
    @dghubble
    dghubble committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    6300383 View commit details
    Browse the repository at this point in the history

  2. Fix typo in internal template variable name 

    * ssh_authorized_keys should be ssh_authorized_key to match the user
facing variable which only allows a single SSH authorized key
    @dghubble
    dghubble committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    251a145 View commit details
    Browse the repository at this point in the history

  3. Remove controller_preemptible option on Google Cloud 

    * Controller preemption is not safe or covered in documentation. Delete
the option, the variable is a holdover from old experiments
* Note, worker_preemeptible is still a great feature that's supported
    @dghubble
    dghubble committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    26a291a View commit details
    Browse the repository at this point in the history

  4. Require google provider version ~> 1.1 

    * Require google provider plugin 1.1 or higher which includes fix:
hashicorp/terraform-provider-google#574
* Remove workaround which statically set the persistent disk name
* Original reasons for workaround in a97df83 or GH #34
    @dghubble
    dghubble committed Nov 4, 2017
    Configuration menu
    Copy the full SHA
    a48dd9e View commit details
    Browse the repository at this point in the history