Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

패키지 업데이트 및 개발 환경 개선 #4

Merged
merged 9 commits into from
Aug 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
{
"editor.defaultFormatter": "biomejs.biome"
"editor.defaultFormatter": "biomejs.biome",
"[typescript]": {
"editor.defaultFormatter": "biomejs.biome"
},
"[json]": {
"editor.defaultFormatter": "biomejs.biome"
}
}
8 changes: 5 additions & 3 deletions biome.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"$schema": "https://biomejs.dev/schemas/1.7.3/schema.json",
"$schema": "https://biomejs.dev/schemas/1.8.3/schema.json",
"organizeImports": {
"enabled": true
},
Expand All @@ -9,7 +9,9 @@
"recommended": true
}
},
"files": {
"ignore": ["dist", "packages/server-sdk/package.json"]
"vcs": {
"enabled": true,
"clientKind": "git",
"useIgnoreFile": true
}
}
2 changes: 1 addition & 1 deletion examples/express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,6 @@
"license": "(Apache-2.0 OR MIT)",
"devDependencies": {
"@types/express": "^4.17.21",
"tsx": "^4.11.2"
"tsx": "^4.16.5"
}
}
20 changes: 15 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"name": "server-sdk-js",
"private": true,
"type": "module",
"scripts": {
Expand All @@ -10,11 +11,20 @@
"example:express": "pnpm turbo run start --filter @portone/server-sdk-example-express"
},
"devDependencies": {
"@biomejs/biome": "1.7.3",
"@changesets/cli": "^2.27.5",
"turbo": "^1.13.3",
"typescript": "^5.4.5"
"@biomejs/biome": "1.8.3",
"@changesets/cli": "^2.27.7",
"turbo": "^2.0.11",
"typescript": "^5.5.4"
},
"pnpm": {
"packageExtensions": {
"[email protected]": {
"dependencies": {
"mkdist": "^1.5.4"
}
}
}
},
"license": "(Apache-2.0 OR MIT)",
"packageManager": "pnpm@9.1.3"
"packageManager": "pnpm@9.6.0"
}
17 changes: 5 additions & 12 deletions packages/server-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@
"type": "module",
"version": "0.1.0",
"description": "PortOne JavaScript SDK for server-side usage",
"keywords": [
"PortOne",
"payment",
"포트원",
"결제 연동"
],
"keywords": ["PortOne", "payment", "포트원", "결제 연동"],
"author": {
"name": "portone-dx",
"email": "[email protected]"
Expand Down Expand Up @@ -36,14 +31,12 @@
},
"devDependencies": {
"@expo/spawn-async": "^1.7.2",
"@types/node": "^20.12.12",
"@vitest/ui": "^1.6.0",
"@types/node": "^20.14.13",
"@vitest/ui": "^2.0.5",
"unbuild": "^2.0.0",
"vitest": "^1.6.0"
"vitest": "^2.0.5"
},
"files": [
"dist"
],
"files": ["dist"],
"sideEffects": false,
"license": "(Apache-2.0 OR MIT)"
}
10 changes: 5 additions & 5 deletions packages/server-sdk/tests/index.test.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import * as fs from "node:fs/promises";
import { createRequire } from "node:module";
import spawnAsync from "@expo/spawn-async";
import { afterAll, beforeAll, describe, expect, test } from "vitest";
import { beforeAll, describe, expect, test } from "vitest";

let uuid: string;

Expand All @@ -21,13 +21,13 @@ beforeAll(async () => {
"-C",
`./temp/${uuid}`,
]);
});

afterAll(async () => {
await fs.rm("./temp", { recursive: true, force: true });
return async () => {
await fs.rm(`./temp/${uuid}`, { recursive: true, force: true });
};
});

describe("can be imported", () => {
describe.concurrent("can be imported", () => {
CirnoV marked this conversation as resolved.
Show resolved Hide resolved
test("import", async () => {
const sdk = await import(`../temp/${uuid}/package`);
expect(sdk).toMatchObject({});
Expand Down
9 changes: 8 additions & 1 deletion packages/server-sdk/vitest.config.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,10 @@
import { defineConfig } from "vitest/config";

export default defineConfig({});
export default defineConfig({
server: {
fs: {
// https://github.com/vitest-dev/vitest/issues/6152
cachedChecks: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 왜 끄는지 주석 있으면 좋을 것 같습니다.

},
},
});
Loading