Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rubocop debug issue after update to 1.45.1 version #316

Closed
pengyin-shan opened this issue Feb 13, 2023 · 2 comments
Closed

Fix rubocop debug issue after update to 1.45.1 version #316

pengyin-shan opened this issue Feb 13, 2023 · 2 comments
Assignees
@pengyin-shan

Comments

@pengyin-shan
Copy link

pengyin-shan commented Feb 13, 2023 •
edited
Loading

In 3.1.0 release, Rubocop starts to complain about debugging messages after upgrading to 1.45.1. roadmap code
didn't see such an issue and it is in 1.44.1:
Screenshot 2023-02-13 at 3 34 52 PM

Need to fix it before 3.1.0 formal release, or choose to downgrade rubocop.
@pengyin-shan pengyin-shan self-assigned this Feb 13, 2023
@pengyin-shan
Copy link
Author

Follow-up: rubocop 1.45.0 (rubocop/rubocop#11517) added debugger detection that will affect most of rake tasks. Will create a follow-up to main codebase.

@pengyin-shan pengyin-shan mentioned this issue Feb 13, 2023
Closed
@pengyin-shan
Copy link
Author

submitted pr to both DMP Assistant and Roadmap, thus close this ticket

This was referenced Feb 17, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pengyin-shan pengyin-shan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pengyin-shan