Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Dockerfile, multiple 'apt-get update' commands #213

Closed
nmacgreg opened this issue Jun 27, 2022 · 3 comments
Closed

In Dockerfile, multiple 'apt-get update' commands #213

nmacgreg opened this issue Jun 27, 2022 · 3 comments

Comments

@nmacgreg
Copy link
Collaborator

What version of the DMPRoadmap code are you running? (e.g. v2.2.0)
v3.0.12

Expected behaviour:
In the Dockerfile, there are 2 statements which run , apt-get update. Once should be enough!

Actual behaviour:
Line 4: 4 RUN apt-get update -qq && \
Line 30: 30 RUN apt-get update && apt-get install -y yarn

Steps to reproduce:
Use eyeballs!

@pengyin-shan
Copy link

From what I understand (pls correct me if I'm wrong), the second apt-get is to force the environment to fix environment after installing node 12, so we can then install yarn.
I guess that we, at one time long ago, want DMP Assisant running in node 12 only.

We can remove the extra step after upgrading to node 16 (i.e. use the system node directly)

@pengyin-shan
Copy link

@isawil : you can assign this ticket to the new developer, we could combine this with the node 16 upgrade.

@aaronskiba
Copy link
Collaborator

This issue still exists, but I am closing it and adding it's details to issue #556 Update Docker Setup For Development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants