Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix resync-state kafka listener bug #931

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

shalev007
Copy link
Contributor

@shalev007 shalev007 commented Aug 21, 2024

  • fix: kafka listener constant resync loop
  • feat: bump version

Description

Bugfix

! What - Fix kafka listener never ending loop of resyncs bug
- Why - This bug was created when we started to updated the resyncState along with integration data,
- therefor each update would create a new audit-log change which triggered the Kafka listener to start a new resync
+ How - we validate that it was not an update created by the resyc-state by comparing them

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

Screenshots

Include screenshots from your environment showing how the resources of the integration will look.

API Documentation

Provide links to the API documentation used for this integration.

@shalev007 shalev007 requested a review from a team as a code owner August 21, 2024 17:02
Copy link
Contributor

@Tankilevitch Tankilevitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to bump and add changelog as previous version has not been released yet

@shalev007 shalev007 merged commit 750dbe9 into main Aug 21, 2024
12 checks passed
@shalev007 shalev007 deleted the PORT-10006-ocean-core-fix-kafka-listener-bug branch August 21, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants