✨ feat(cookie-consent-banner): introduce ::part pseudo selector #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pboeder
reviewed
Sep 13, 2023
| <slot /> | ||
| </p> | ||
| {Boolean(this.isShownSettings) && ( | ||
| <div class="cc_settings"> | ||
| <p class="cc_settings_description"> | ||
| <p part="description" class="cc_settings_description"> |
There was a problem hiding this comment.
Is it intentional that the part "description" is there twice?
There was a problem hiding this comment.
I guess you're right, let's use description-settings and description-main separately.
pboeder
reviewed
Sep 13, 2023
| @@ -280,6 +285,7 @@ export class CookieConsentBanner { | |||
| {!this.isShownSettings && | |||
| !!this.btnLabelOnlyEssentialAndContinue && ( | |||
| <button | |||
| part="secondary-button" | |||
There was a problem hiding this comment.
I would split the naming of both buttons.
There was a problem hiding this comment.
Switched to these parts: button-accept-all, button-persist-selection and button-essential-only
pboeder
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to style parts of the web component using the CSS
::partselector. Thereby we can provide nice looking defaults and for customization either via the easy-to-use CSS variable solution or via the fully flexible::part()API.Pull Request Checklist