Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not giving a country name returns Eritrea #42

Open
voidus opened this issue Feb 4, 2022 · 0 comments
Open

Not giving a country name returns Eritrea #42

voidus opened this issue Feb 4, 2022 · 0 comments

Comments

@voidus
Copy link
Contributor

voidus commented Feb 4, 2022 

> CountryInfo().name()
'eritrea'

Question is, what is good behaviour here? I'd argue that since a CountryInfo object represents information about a specific country, a constructor argument should be mandatory.

Probably easier to do #41 first, since right now, accessing .all() requires constructing an object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@voidus