Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adopt reusable chart API convention? #1

Open
bollwyvl opened this issue Aug 14, 2015 · 1 comment
Open

adopt reusable chart API convention? #1

bollwyvl opened this issue Aug 14, 2015 · 1 comment

Comments

@bollwyvl
Copy link

This looks great, but it feels a bit imperative vs the fluent, chainable style of d3 where it is most likely to be used. Specifically, you have to .each each time you'd want to use this for particular data.

Not that I can imagine what they'd be (other than maybe direction), but as you add more configurable features, rather than passing them as a big old jquery-style config object, how about an API like this (loosely based on the example in the readme):

var transpose = polymorph.transpose()
  .before(d3.geo.path().projection(proj))
  .after(circleIt);

shape.transition()
  .attr(d, transpose)
.transition()
  .attr(d, transpose.direction(false))
@thednp
Copy link

thednp commented Feb 23, 2016

The problem is, this code isn't working outside of D3, as stated by developer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants