From c1488a7207584ce5e4300957b9b4fc781fec0cee Mon Sep 17 00:00:00 2001 From: Andy Martin Date: Mon, 8 Oct 2018 22:37:49 -0400 Subject: [PATCH 1/3] add secure: true --- src/clients/firebase.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/clients/firebase.js b/src/clients/firebase.js index 6740cd2ba3..c70508c0b5 100644 --- a/src/clients/firebase.js +++ b/src/clients/firebase.js @@ -262,7 +262,8 @@ export function setSessionUid() { Cookies.set( VALID_SESSION_UID_COOKIE, uid, - {expires: new Date(Date.now() + SESSION_TTL_MS)}, + {expires: new Date(Date.now() + SESSION_TTL_MS), + secure: true}, ); } } From 446336760f4a749200f8fd57539f32196bbb6134 Mon Sep 17 00:00:00 2001 From: Andy Martin Date: Mon, 8 Oct 2018 23:01:08 -0400 Subject: [PATCH 2/3] fix indentation to un-break CI tests --- src/clients/firebase.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/clients/firebase.js b/src/clients/firebase.js index c70508c0b5..2de0e81f2b 100644 --- a/src/clients/firebase.js +++ b/src/clients/firebase.js @@ -262,8 +262,10 @@ export function setSessionUid() { Cookies.set( VALID_SESSION_UID_COOKIE, uid, - {expires: new Date(Date.now() + SESSION_TTL_MS), - secure: true}, + { + expires: new Date(Date.now() + SESSION_TTL_MS), + secure: true + }, ); } } From d7b87e63449db5e454b564c74482d398e10cd428 Mon Sep 17 00:00:00 2001 From: Andy Martin Date: Mon, 8 Oct 2018 23:08:45 -0400 Subject: [PATCH 3/3] fix: error Missing trailing comma --- src/clients/firebase.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/clients/firebase.js b/src/clients/firebase.js index 2de0e81f2b..94c4882a60 100644 --- a/src/clients/firebase.js +++ b/src/clients/firebase.js @@ -264,7 +264,7 @@ export function setSessionUid() { uid, { expires: new Date(Date.now() + SESSION_TTL_MS), - secure: true + secure: true, }, ); }