Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set SYSFB_SIMPLEFB=y #177

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Set SYSFB_SIMPLEFB=y #177

merged 1 commit into from
Sep 19, 2022

Conversation

jackpot51
Copy link
Member

@jackpot51 jackpot51 commented Sep 19, 2022 •
edited by leviport
Loading

Test if there are any changes to NVIDIA decrypt prompt. At the least, test the following GPU variants:

  • Desktop AMD discrete (thelio-r2 + 5500XT)
  • Desktop AMD integrated (thelio-r2 + 5650g)
  • Desktop Intel integrated (thelio-mira-b3 + i9-12900KS)
  • Desktop NVIDIA discrete with 470 driver (mega-r2 w/2080 & GT710)
  • Desktop NVIDIA discrete with 515 driver (mega-r2 w/3060Ti & 2080)
  • Laptop AMD integrated (HP Dev One)
  • Laptop AMD/NVIDIA hybrid with 515 driver, all graphics modes (kudu)
  • Laptop Intel/NVIDIA hybrid with 515 driver, all graphics modes (gaze17)
  • Laptop Intel integrated (lemp9)
  • Laptop NVIDIA discrete with 515 driver (bonw13)

@jackpot51 jackpot51 requested review from a team September 19, 2022 17:10
@jackpot51 jackpot51 self-assigned this Sep 19, 2022
@jackpot51 jackpot51 mentioned this pull request Sep 19, 2022
Merged
This was referenced Sep 19, 2022
Closed
Closed
Merged
leviport
leviport approved these changes Sep 19, 2022
View reviewed changes
Copy link
Member

@leviport leviport left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is looking good

@jackpot51 jackpot51 merged commit d522b3c into master Sep 19, 2022
@jackpot51 jackpot51 deleted the sysfb-simplefb_jammy branch September 19, 2022 22:14
@jackpot51 jackpot51 mentioned this pull request Sep 19, 2022
Closed
@leviport leviport mentioned this pull request Sep 21, 2022
Closed
@pbui
Copy link

pbui commented Sep 21, 2022

This change appears to be causing issues according to the r/pop_os subreddit:

  1. https://reddit.com/xk00n7
  2. https://reddit.com/xk8m4t
  3. https://reddit.com/xk1vra

@jackpot51
Copy link
Member Author

I have reverted the change for now. It looks like one configuration breaks EFIFB on some systems, another configuration breaks it on others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviport leviport leviport approved these changes

Assignees

@jackpot51 jackpot51

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackpot51 @pbui @leviport