Skip to content

Commit

Permalink
PCI: aerdrv: remove magical ROOT_ERR_STATUS_MASKS
Browse files Browse the repository at this point in the history
Make it clear that we only interest in 2 *_RCV bits.

Signed-off-by: Hidetoshi Seto <[email protected]>
Reviewed-by: Kenji Kaneshige <[email protected]>
Signed-off-by: Jesse Barnes <[email protected]>
  • Loading branch information
Hidetoshi Seto authored and jbarnes993 committed May 11, 2010
1 parent f647a44 commit e167bfc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/pci/pcie/aer/aerdrv.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ irqreturn_t aer_irq(int irq, void *context)

/* Read error status */
pci_read_config_dword(pdev->port, pos + PCI_ERR_ROOT_STATUS, &status);
if (!(status & ROOT_ERR_STATUS_MASKS)) {
if (!(status & (PCI_ERR_ROOT_UNCOR_RCV|PCI_ERR_ROOT_COR_RCV))) {
spin_unlock_irqrestore(&rpc->e_lock, flags);
return IRQ_NONE;
}
Expand Down
3 changes: 0 additions & 3 deletions drivers/pci/pcie/aer/aerdrv.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@
#define AER_FATAL 1
#define AER_CORRECTABLE 2

/* Root Error Status Register Bits */
#define ROOT_ERR_STATUS_MASKS 0x0f

#define SYSTEM_ERROR_INTR_ON_MESG_MASK (PCI_EXP_RTCTL_SECEE| \
PCI_EXP_RTCTL_SENFEE| \
PCI_EXP_RTCTL_SEFEE)
Expand Down

0 comments on commit e167bfc

Please sign in to comment.