Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent emoji rendering #327

Open
richardhozak opened this issue Nov 16, 2024 · 1 comment · May be fixed by #328
Open

Inconsistent emoji rendering #327

richardhozak opened this issue Nov 16, 2024 · 1 comment · May be fixed by #328

Comments

@richardhozak
Copy link

richardhozak commented Nov 16, 2024

Hello, while trying to update cosmic-text from version v0.7-ish (commit e00109d) to latest version v0.12.1 I've noticed there is a regression in rendering emojis.

The latest version renders only some emojis in color while rendering other in black/white version.

Here is a screenshot how it is rendered with 0.12.1
Screenshot from 2024-11-16 20-05-13

And here is a screenshot on how it was rendered with e00109d and v0.6
image

Notice the different emojis. The text also looks different but not incorrect.

I've also tested this with v0.11, v0.10, v0.9 and v0.8 and they all look the same as v0.12.1.
I've also tested with release v0.7, that also looks the same as v0.12.1. Then I tried downgrading to 0.6 and the emojis render correctly, so it must be some change between 0.6 and 0.7.

Is there anything I can test on my system to debug this issue or help you debug the issue?

@richardhozak
Copy link
Author

So I've checked all the commits between 0.6.0...0.7.0 and found the regression which is commit 66288ab Noto Color Emoji should probably be higher in the fallback list. Will try to implement fix...

richardhozak added a commit to richardhozak/cosmic-text that referenced this issue Nov 16, 2024
This reverts commit 66288ab.

Note that putting "Noto Color Emoji" anywhere lower (even just below "DejaVu Sans")
creates issue described in pop-os#327

Putting it above "Noto Sans" breaks text rendering completely.

With the commit reverted I cannot reproduce the original issue
pop-os#68 the commit
66288ab was supposed to fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant