Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cosmic workspace protocol v2 #38

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

morr0ne
Copy link

@morr0ne morr0ne commented Oct 5, 2024

This PR introduces version 2 of the workspace protocol, which resolves the naming conflicts between events and requests. I’ve renamed the conflicting events to "destroyed," as this more accurately reflects their purpose. I’ve gone through the code and updated it accordingly, though there may be areas I missed.

Regarding the copyright header, I assume I need to add myself to provide the necessary permissions. However, I’ve held off on that for now since I haven’t rolled out a protocol before, so any guidance here would be helpful.

Marking this as a draft for now, as it's still open for feedback and further discussion.

fixes #36

@ids1024
Copy link
Member

ids1024 commented Oct 7, 2024

Note that as of recently, COSMIC isn't the only project using cosmic-workspace-unstable-v1: LBCrion/sfwbar#212, labwc/labwc#2030. Which makes introducing a v2 protocol a bit less ideal.

Wayland-protocols is trying to get better at merging protocols in a reasonable timeframe, so perhaps it would be possible to address any remaining issues with https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40 and finally get that merged upstream, so we can replace the COSMIC protocol with that one instead.

@ids1024
Copy link
Member

ids1024 commented Nov 14, 2024

https://gitlab.freedesktop.org/wayland/wayland-protocols/-/merge_requests/40 has indeed been making some progress, and hopefully can be approved and merged in to not too distant future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request and event naming conflict in the cosmic workspace protocol
2 participants