Do not catch foreign exceptions in Pony try blocks #2466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
added
the
changelog - fixed
jemc
approved these changes
Jan 5, 2018
Praetonus
force-pushed
the
fix-2455
branch
3 times, most recently
from
6bf9913
to
3a5b892
Compare
|
This has some issues on windows. If a C++ exception is thrown and there is a Pony frame between the throwing location and the C++ catch frame, the exception won't be caught by the C++ catch frame. I'm not a windows expert so I don't really know what's wrong here. |
|
Decided on the sync to document this as not working yet on Windows, but merge with the test disabled on Windows once the Travis build passes. |
This doesn't work on windows. The foreign code doesn't catch foreign exceptions if they've traversed a Pony frame. This is suspected to be related to the way SEH and LLVM exception code generation interact.
Praetonus
removed
do not merge
|
I've disabled the test on windows and added a manual changelog entry. |
|
CI is passing, merging. |
dipinhora
pushed a commit
to dipinhora/ponyc
that referenced
this pull request
Jun 5, 2018
This doesn't work on windows. The foreign code doesn't catch foreign exceptions if they've traversed a Pony frame. This is suspected to be related to the way SEH and LLVM exception code generation interact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.