Fail pony_start if ASIO backend wasn't successfully initialized #2381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the ASIO backend could fail initialization but the runtime would continue to start up anyway resulting in segfaults or assertion failures. This commit changes things so that if the backend initialization fails, the runtime exits immediately with an error. This commit also fixes the asio restart logic from PR ponylang#2373 to properly re-initialize the backend first.
jemc
added
the
changelog - fixed
jemc
approved these changes
Nov 27, 2017
ponylang-main
added a commit
that referenced
this pull request
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the ASIO backend could fail initialization
but the runtime would continue to start up anyway resulting in
segfaults or assertion failures.
This commit changes things so that if the backend initialization
fails, the runtime exits immediately with an error.
This commit also fixes the asio restart logic from PR #2373 to
properly re-initialize the backend first.