Make ContentsLogger implement the Logger interface #2330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, ContentsLogger did not implement the Logger interface. There were also some inconsistencies between the parameter names in the Logger apply method across its implementations.
Theodus
added
the
changelog - fixed
|
Multiple failures on Travis for "The job exceeded the maximum time limit for jobs, and has been terminated", restarting those tests. |
mfelsche
approved these changes
Nov 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
ContentsLoggerdid not implement theLogger interface. Therewere also some inconsistencies between the parameter names in the
Loggerapply method across its implementations.