Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect kevent structure size #2312

Merged
merged 1 commit into from
Oct 29, 2017
Merged

Fix incorrect kevent structure size #2312

merged 1 commit into from
Oct 29, 2017

Conversation

SeanTAllen
Copy link
Member

We might try to add up to 4 items to the array but we only sized for 3.
This bug date back a couple years to when signal handling support was
added.

We might try to add up to 4 items to the array but we only sized for 3.
This bug date back a couple years to when signal handling support was
added.
@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Oct 27, 2017
@sylvanc
Copy link
Contributor

sylvanc commented Oct 29, 2017

This won't cause an overflow in practice, as SIGNAL and TIMER are mutually exclusive, but should be merged anyway as it is The Right Thing (tm).

@sylvanc sylvanc merged commit 28723a7 into master Oct 29, 2017
ponylang-main added a commit that referenced this pull request Oct 29, 2017
@SeanTAllen SeanTAllen deleted the kqueue-bug branch October 29, 2017 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants