Fix indent detection when lexing docstrings that contain whitespace-only lines.

[mfelsche]

fixes #2130

[jemc]

You don't need the {/} braces for this - the prevailing style in this codebase is to omit braces when the body is just one statement.

if(!isspace(c))
  has_non_ws = true;

Also note that if the braces were to be included (for a multi-line if statement), the prevailing style is to place the opening brace on its own line:

if(!isspace(c))
{
  has_non_ws = true;
  some_other_statement();
}

[mfelsche]

right, i still struggle to get my editor (and my head) to respect those formatting rules.

[jemc]

This is ready to merge when CI passes.

I added the changelog label and edited the ticket title to read like a changelog entry, so that the automatic changelog bot can do its work.

Thanks!

[SeanTAllen]

Thanks @mfelsche

[SeanTAllen]

one small request for the future @mfelsche the "fixes" is nice ideally information about the "why" would be in the commit message itself rather than just a link to the issue. the best case for the body of that commit would be an explanation of the problem as well as a link to the github issue.

[mfelsche]

Point taken. I have to admit i was in a great hurry when i pushed and opened the pr. Will take more care on future contribution.

[SeanTAllen]

thanks @mfelsche