Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xoroshiro128+ implementation #1909

Merged
merged 1 commit into from
May 14, 2017
Merged

xoroshiro128+ implementation #1909

merged 1 commit into from
May 14, 2017

Conversation

sylvanc
Copy link
Contributor

@sylvanc sylvanc commented May 14, 2017

This adds both xoroshiro128+ and xorshift128+ implementations.
The XorOshiro128Plus type should be used as the default
non-cryptographic PRNG. To make this simpler, a new Rand type
that aliases the preferred PRNG has been added, so that if a
new PRNG becomes preferred, the type alias can be changed.

@sylvanc sylvanc added the changelog - added Automatically add "Added" CHANGELOG entry on merge label May 14, 2017
@SeanTAllen
Copy link
Member

I don't think the commit title on this is particularly CHANGELOG friendly. It should be updated in some fashion. I think the commit comment itself should also be amended to explain why this change is being made.

This adds both xoroshiro128+ and xorshift128+ implementations.
The XorOshiro128Plus type should be used as the default
non-cryptographic PRNG. To make this simpler, a new Rand type
that aliases the preferred PRNG has been added, so that if a
new PRNG becomes preferred, the type alias can be changed.
@SeanTAllen SeanTAllen merged commit 35f91d1 into master May 14, 2017
ponylang-main added a commit that referenced this pull request May 14, 2017
@SeanTAllen SeanTAllen deleted the xoroshiro branch June 7, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants