Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buffered.Reader.append accept any ByteSeq. #1644

Merged
merged 1 commit into from
Mar 15, 2017
Merged

Make buffered.Reader.append accept any ByteSeq. #1644

merged 1 commit into from
Mar 15, 2017

Commits on Mar 8, 2017

  1. Fix buffered.Reader.append to accept any ByteSeq. 

    This is an issue of principle-of-least-surprise, since buffered.Writer
emits ByteSeqs in its output, so having buffered.Reader accept ByteSeqs
at its input makes it symmetrical and least surprising.

This doesn't break any user code, since it only makes an argument type
more general, and does not make any return types more general.
    @jemc
    jemc committed Mar 8, 2017
    Configuration menu
    Copy the full SHA
    dfb9914 View commit details
    Browse the repository at this point in the history