Make buffered.Reader.append accept any ByteSeq. #1644
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an issue of principle-of-least-surprise, since
buffered.Writer
emits
ByteSeq
s in its output, so havingbuffered.Reader
acceptByteSeq
sat its input makes it symmetrical and least surprising.
This doesn't break any user code, since it only makes an argument type
more general, and does not make any return types more general.
This came up in a discussion in #1639.