Correctly resubscribe TCPConnection to ASIO events after throttling #1558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the TCPConnection/EPoll One Shot changes that I previously submitted, there was a bug where when the TCPConnection experiences throttling, it won't ever get notified when we are ready to send again. This patch addresses that in the short term. There's a PR coming from Dipin Hora that addresses this in a better fashion and handles a subtle race condition in One Shot ASIO events. This small patch should suffice in the meantime and get master back to a correct state.
SeanTAllen
added
the
changelog - fixed
|
Would be nice if we had some tests that covered this, but I believe it was discussed in #1539 that it wouldn't be practical. |
|
@jemc i think what we need are Spy type tests that verify the contract is working correctly. We are lacking a bit on tooling for that at the moment. I started a discussion with Sylvan over the weekend on what would be required to write a nice spy tool for Pony. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the TCPConnection/EPoll One Shot changes that I previously
submitted, there was a bug where when the TCPConnection experiences
throttling, it won't ever get notified when we are ready to send again.
This patch addresses that in the short term. There's a PR coming from
Dipin Hora that addresses this in a better fashion and handles a
subtle race condition in One Shot ASIO events. This small patch
should suffice in the meantime and get master back to a correct state.
Close #1539