Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor invoke optimizations #256

Merged
merged 8 commits into from
Dec 19, 2023
Merged

Minor invoke optimizations #256

merged 8 commits into from
Dec 19, 2023

Conversation

MarcGuiselin
Copy link
Contributor

No description provided.

@MarcGuiselin MarcGuiselin mentioned this pull request Nov 27, 2023
Open
@MarcGuiselin
Copy link
Contributor Author

@namesty Anything stopping this from being merged?

@MarcGuiselin
Copy link
Contributor Author

MarcGuiselin commented Dec 17, 2023 •
edited
Loading

I made one more change, since I'd missed the fact that the buffers were not actually being written to. I've used Vec::with_capacity before when using ffi, so I forgot to set the vector length here.

@namesty namesty merged commit 353ed87 into polywrap:main Dec 19, 2023
@namesty
Copy link
Contributor

namesty commented Dec 19, 2023

@namesty Anything stopping this from being merged?

Nope, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@namesty namesty namesty approved these changes

@nerfZael nerfZael nerfZael approved these changes

@cbrzn cbrzn Awaiting requested review from cbrzn cbrzn is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcGuiselin @namesty @nerfZael