renamed PolywrapClient to Client

[krisbitney]

Closes #236

[codecov]

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Current head 65c4dfe differs from pull request most recent head 74af126. Consider uploading reports for the commit 74af126 to get more accurate results

Files Changed	Coverage
packages/core/src/client.rs	ø
packages/client/src/client.rs	100.00%
packages/core/src/resolution/helpers.rs	100.00%
packages/native/src/builder.rs	100.00%
packages/native/src/client.rs	100.00%
packages/plugins/logger/src/lib.rs	100.00%

📢 Thoughts on this report? Let us know!.

[cbrzn]

this is awesome! thanks for pushing this 🙏

do you think we should also change the PolywrapClientConfigBuilder to ClientConfigBuilder? As well as PolywrapClientConfig to ClientConfig? (In another PR ofc)

[krisbitney]

this is awesome! thanks for pushing this 🙏

do you think we should also change the PolywrapClientConfigBuilder to ClientConfigBuilder? As well as PolywrapClientConfig to ClientConfig? (In another PR ofc)

Yes, that make sense. I'll make those changes!

[cbrzn]

i feel that this should be something like ClientBuilderConfig and the CoreClientConfig be ClientConfig - I feel that the Core prefix is non intuitive. Wdyt? Also cc to @namesty and @nerfZael to see what they think

[dOrgJelli]

I think we should make the most user-facing type the easiest to understand and read. So, that would mean that the config used by the builder is the ClientConfig, and the "fully built config" that's used by the client would be the CoreClientConfig.

[cbrzn]

I think we should make the most user-facing type the easiest to understand and read. So, that would mean that the config used by the builder is the ClientConfig, and the "fully built config" that's used by the client would be the CoreClientConfig.

yah in my opinion that's not the easiest to understand and read but rather confusing. if I see this for the first time I would ask to myself "what's the difference between a client and a core client" and why do they have different attributes. from my perspective, this can be really simplified to say that one is the builder attributes and the other is the client attributes (but again, this is my opinion and I can be completely wrong)

[cbrzn]

anyways, I will merge this because it is a nit, and there's no need to block this

[dOrgJelli]

LGTM! 🔥