reverted renaming from PR #234 #247

krisbitney · 2023-10-27T07:57:01Z

Closes #246

codecov · 2023-10-27T08:28:25Z

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
packages/builder/src/polywrap_client_config.rs	`95.54% <100.00%> (-0.41%)`	⬇️
packages/client/src/client.rs	`93.86% <100.00%> (ø)`
packages/core/src/client.rs	`54.54% <ø> (ø)`
packages/core/src/resolution/helpers.rs	`97.14% <100.00%> (ø)`
packages/default-config/src/system_config.rs	`99.17% <100.00%> (ø)`
packages/native/src/builder.rs	`100.00% <100.00%> (ø)`
packages/native/src/client.rs	`84.95% <100.00%> (ø)`
packages/plugins/logger/src/lib.rs	`77.27% <100.00%> (ø)`
packages/default-config/src/web3_config.rs	`94.54% <66.66%> (ø)`

📢 Thoughts on this report? Let us know!.

dOrgJelli

I thought we were just going to export PolywrapClient... alongside the new shorter names so that it's backwards compatible?

pileks · 2023-10-31T11:09:55Z

I thought we were just going to export PolywrapClient... alongside the new shorter names so that it's backwards compatible?

@dOrgJelli I've opened a separate PR which does this exactly: #248

reverted renaming from PR#234

cc57109

krisbitney requested review from namesty, cbrzn and nerfZael as code owners October 27, 2023 07:57

krisbitney requested review from pileks, dOrgJelli and Niraj-Kamdar October 27, 2023 07:57

dOrgJelli requested changes Oct 31, 2023

View reviewed changes

dOrgJelli closed this Nov 23, 2023