-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit job launch rate/add auth #28
Comments
I like the rate throttling technique a bit more than authentication |
I haven't used flask before but looking at the docs I think it should be pretty simple to add throttling (and maybe some statistics and possibly https://github.com/flot/flot plots because once I learn flask I may as well bring something to the table) and ajaxify the post method (I can't stand waiting for the post :) ). I will check it out this weekend. |
That would be awesome @crbates! Flask is super simple, btw - though we abuse it a bit here. |
The big question here is if we want a method of data storage/some sort of database and the associated dependencies. Without some permanent storage, we could:
With external storage (sqlite maybe?) we could have...well...anything. Custom user/rights management, sophisticated throttling rules, plots and statistics, you name it. But I don't know in which direction you want to go with this dashboard. Is this just supposed to be a plain and simple "click this to manually run a test" page, or should this eveolve into some other, bigger thing? |
I think a bit would be putting it lightly. I will look at this more when I have some more time but this whole flask obfuscated by polyphemus plugins seems like a recipe for difficult to track down errors to quick and dirty solutions. I still think stats and charts would be really nice to add but my bandwidth is currently -- . |
Yeah, I couldn't think of a better way to do this without wholesale just writing django plugins or buying into some other big framework. Flask functions just show up here as plugin methods. It should be noted that not all polyphemus plugins are web services. Sometimes you just want to add steps to the execution pipeline. All apologies if it doesn't immediately fit your brain :) |
I just made the mistake of reading flask docs before polyphemus docs. Now that pyne/pyne#338 is mostly ready I will probably hack something together for this tomorrow. |
Limit the number of jobs that can be launched per minute/hour/day to reasonable numbers and/or add authentication to address @cbrachem's concerns about bot attacks.
The text was updated successfully, but these errors were encountered: