Add semantic version comparison. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hug0-Drelon
force-pushed
the
ver-comp
branch
from
842a31b
to
f2c4cc3
Compare
manooweb
requested changes
Feb 22, 2024
|
You can use Debian's (also derivatives like Ubuntu) |
|
Thanks for the suggestion @szepeviktor! |
szepeviktor
reviewed
Feb 23, 2024
Co-authored-by: Viktor Szépe <[email protected]>
manooweb
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #1
Allow third party to run PHPUnit test for old WordPress version which requires old PHPUnit versions.
Use semantic version comparison to achieve that.
How?
version-compareto compare to versions with a optional operator (default to "<").version-compareaction inphpunitaction to require the correct PHPUnit version depending on the current WordPress veersion.Limits
The version compare action is not able to correctly compare two versions if "dev", "latest" or "nightly" is passed for both versions.